Lag in selecting text

JammyDodger · January 26, 2022, 11:13am

I’ve just been attempting to quote the Developer’s guide to Discourse Themes, and when I long-press to select text there’s a significant lag when I drag the cursors to extend the selection.

I’ve tried a few other topics to test, but they seem to work fine (wiki and DiscoToC ones). Not sure what the issue is, but thought it’d be rude to pass by and not mention it.

Android/Chrome

Falco · January 26, 2022, 3:26pm

I can repro the lag.

Looks like we call toMarkdown on the whole post. That post is almost 100k chars long, so it takes quite a while.

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/quote-button.js#L167

      
        
              }
            }
            
            
const _selectedElement = selectedElement();
            const _selectedText = selectedText();
            
            
const $selectedElement = $(_selectedElement);
            const cooked =
              $selectedElement.find(".cooked")[0] ||
              $selectedElement.closest(".cooked")[0];
            const postBody = toMarkdown(cooked.innerHTML);
            
            
let opts = {
              full: _selectedText === postBody,
            };
            
            
for (
              let element = _selectedElement;
              element && element.tagName !== "ARTICLE";
              element = element.parentElement
            ) {

Maybe we can call the server to obtain the markdown here after a certain threshold ?

sam · January 31, 2022, 5:04am

I don’t know … not sure we should add more edge cases there. Maybe we can eliminate this altogether?

I think the intent is to figure out if you selected an entire post … we can figure that out in other ways no maybe by looking at your HTML tree? @joffreyjaffeux could fast edit look directly at cooked for its heuristic?

Topic		Replies	Views
Fast edit doesn't work on content with certain characters Bug fast-edit	22	1151	May 11, 2023
How do I disable Markdown completely? Support	20	2479	August 17, 2016
Why does markdown do this? (whitespace trimming and other features) Dev markdown	6	1844	September 20, 2023
Text selection is cancelled when the AI popup disappears Bug composer , fast-edit	8	761	November 2, 2023
Click To Edit Plugin	20	454	August 30, 2024

Lag in selecting text

Related topics