Links to hidden messages don't clear filters

[Nacho_Caballero]

I don’t know if this is one bug or two, but here are the steps to reproduce them. I’ve had to do it here instead of in try.discourse.org because filtered replies are not enabled there.

1. Go to post #6 in this thread, scroll to the bottom and click to see its 6 replies:

   

2. Scroll to the last post (number #25, which is a direct reply of #6) and click its link to post number #24:
   

   

Expected behavior: post #24 becomes visible (filters might or might not get removed)

Actual behavior: the page scrolls up and down, but #24 never appears

On to bug #2:

3. Click on View 6 hidden replies

   

4. Scroll down until you see post #24 and click its link to post #8

   

Expected behavior: #8 appears

Actual behavior: #7 appears

[Nacho_Caballero]

@pmusaraj If you have time, could you confirm if this is indeed a bug (or two) or if it’s the intended behavior? Maybe I’m misinterpreting something.

[pmusaraj (Penar Musaraj)]

Yes, this looks one and the same bug. It’s a considerable edge case, it is quite rare to link to replies like in the example, but I will add this to my todo list.

[Nacho_Caballero]

A more common case is when the link is actually a @mention notification

[pmusaraj (Penar Musaraj)]

Hmm, I’m not following, how would a mention link to a reply in the same post stream?

[Nacho_Caballero]

I used a link to make the example reproducible, but this was actually reported by a user who was seeing a filtered reply and received a mention on the same topic. When they clicked on the notification, they got the behavior I reported

[pmusaraj (Penar Musaraj)]

This is fixed now @Nacho_Caballero via https://github.com/discourse/discourse/commit/524890c5e437b22c3505b7fbbc3df8acdbc431db

[Nacho_Caballero]

That works perfectly! Thanks, Penar.

That took surprisingly little code to fix, but I don’t think I’d been able to figure it out on my own.