Mailing List Replacement : Email Attachments

Can we think about a possible solution here @riking?

6 Likes

Can I add my own “+1” here as well? Most of the attachments our members will be sending if/when we switch to Discourse will be images, which are displayed inline in notifications, but occasionally they’ll be sending PDFs and other miscellaneous files that really do need to be attached. An option to include non-image attachments would go a long way to helping us in this area.

This may be relevant too: http://help.mandrill.com/entries/21763806-Does-Mandrill-support-attachments-

1 Like

Has there been any movement on this issue? It would be a nice feature to have to complete mailing-list parity.

3 Likes

Same boat! Please :). Just moved our nonprofit association to discourse hosted product.

Thanks

I thought we fully support attachments, right @zogstrip ?

We support attachments in incoming emails. Not outgoing emails (ie. notifications).

2 Likes

Can this please be changed? What’s the point putting a picture in to a message if it’s not going to be received? The sender has no idea who (if any) of their recipients will be viewing it in the web browser. And worse still, the average user has no idea about this limitation.

It appears there is a misunderstanding; this only applies to attachments like a word document, not a jpg or png or gif image.

So unless you are sending out Microsoft Word documents or other unusual attachments, I would not be concerned.

2 Likes

Also note that these attachment will appear as links, just as in the web app. The only restriction is that they won’t additionally be included in the mail as an actual attached file :slight_smile:

4 Likes

Sorry about that.

When I say Discourse doesn’t support attachments in outgoing emails, I actually mean that files other than images, will not be attached to emails sent by Discourse.

Images will be inlined and other kind of files will be linked like @fefrei noted.

3 Likes

Perfect! Thanks for clearing that up, guys. Nice, fast, personal help as always

1 Like

@maja can you have a look at “converting” attachments (ie. uploads that aren’t images) in outgoing emails to proper attachments?

4 Likes

That would be amazing if possible. :heart:

4 Likes

So someone reminded me of reasons why I should retract, or at least be cautious, about my above statements:

  1. Could create a ton of data sent over email providers, possibly increasing costs.
  2. Attaching files to email promotes behavior that has increased security risks (email attachments are still a huge attack vector).
  3. Creates a lot of copies of the same file vs. one copy living on the Discourse server.
  4. No way to “take back” the attachment (via post editing) if the wrong file is uploaded and emailed out automatically to N people by accident.
  5. Probably some others we didn’t think of.

So … YMMV. I at least hope this option is a switch with default off. :slight_smile:

3 Likes

It sure is :wink: @maja is working on it

https://github.com/discourse/discourse/pull/7571

3 Likes

Not sure you can take it back in even in the current state. If I edit a post and change/delete the attachment, is the original file deleted immediately from the Discourse instance or would the link originally sent over the email still work?

In order to add the attachments on to the mail, we have to hold the contents of the file in memory as well.

@maja I think we need to look at some safe guards around here for the maximum number of attachments.

3 Likes

@gerhard can you take over @maja’s PR?

https://github.com/discourse/discourse/pull/7571

4 Likes

This feature has been merged: https://github.com/discourse/discourse/commit/7e0eeed29219a2eacb769e955f7c1c94091e9ad6

It’s disabled by default and can can be configured with the email_total_attachment_size_limit_kb site setting.

6 Likes

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.