'max tags per topic' failing silently

Since this week. we no longer see an error message when you more than max tags per topic on a topic. Instead, the topic just saves, but the additional tags are discarded silently.

2 Likes

Hi,

it should be fixed by

https://github.com/discourse/discourse/pull/9018

I added few tests, hopefully we don’t regress on this anymore.

Thanks.

8 Likes

merged

I found this topic when I wanted to report that max_tags_per_topic fails silently on current tests-passed when it is set to 0.

Repro:

  • set max_tags_per_topic to 0
  • add a tag to a topic
  • see that it’s not added

When max tags per topic is set to 1 and you attempt to add a second tag, it gives a “you can select only 1 item” error message.

I suspect the bug is here , if maximum is 0 then the if expression is false.

2 Likes