Actually, I fluffed the Meta test… I had previously downgraded my test user to TL0 and forgotten about him. Bumping them to TL1 made the Message tab appear. Though that may help me work out why the same is not happening on my test site.
I’ve updated my test site this morning to have another run at this and I’m no longer seeing this issue. The message tabs are now showing up where they’re supposed to for non-staff users. I don’t know if this is a consequence of a fresh update (I can’t see any relevant commits) or possibly a setting I’ve changed/something I’ve done during other issue-testing.
To rule it out, could you update to latest and see if that helps?
(FWIW I also span up a new test site while exploring something else, and the new TL1 test user on there also had the messages tabs displayed in the correct places)
I was doing some run-throughs with the new direct message enabled groups (as well as the existing chat allowed groups) plugin settings during the window when the tabs weren’t there and then were there. There’s a small chance that changing and resetting those may be the trigger?
I have just tried with these chat settings, I already did some testing with other settings earlier to see if there was a bug with those. So maybe I have some old setting that’s still enabled? Not sure…
EDIT: Setting min trust to send messages to 0: new user does make messages appear, even tho I bumped the user to TL1.
EDIT2: So to conclude after the latest finding, with the setup as seen below, no one except admins/mods can see messages. If I set min trust to send messages to 0: new user everyone including TL0 sees the message section. Same behavior on two instances.
personal message enabled groups has some effect, on a user page the message button gets removed if user doesn’t have the required TL. But messages tabs only show when min trust to send messages is set to 0: new user
I updated our Discourse instance to 2.9.0.beta10 but didn’t turn the new sidebar feature on. Our users have noticed that the Personal Message icon has since disappeared
in the menu bar when clicking the upper-right hand avatar, although as admin I can still see mine. Was the icon removed due to the new sidebar menu launch? Any way to get it back? Thank you!
I’ve noticed that on mine too. I think it still records something in the staff logs about the setting change, but linked to the personal_message_allowed_groups. I’ll have to dig a little deeper into that tomorrow, but that may be somewhere to look to see if I can track what I did.
I’m taking a look at this since I added the personal_messages_enabled_groups setting. This behaviour is unexpected:
It looks like what is happening is that changing the enable_personal_messages and min_trust_to_send_messages settings in the UI also change the personal_message_enabled_groups setting. If I uncheck enable_personal_messages and save it, it clears out personal_message_enabled_groups, which reproduces the behaviour shown above. Or if I set the min_trust_level_to_send_messages to TL1, it sets personal_message_enabled_groups to admins.
I will open a PR today to hide the old settings in the UI, and also fix up this part of SiteSettingsController that unconditionally sets the new setting’s value to what we are changing the old setting to, even if override is not set to true:
Will hide the old settings first to stop the bleeding. Make sure you set personal_message_enabled_groups to what you want and leave the other settings as is, and let me know if that’s still not fixing the issue.