like the last image we can give option for that too in that dropdown
Thanks for the mockups @Ahmed_Gagan, how would you see this work at
/my/notifications? Or are you envisioning this only in the user menu?
Should I do
/my/notifications page in a separate PR
I’d make seperate PRs. The design for a full-page interface is likely to be different from one that works in a narrow-width dropdown.
So, ill focus on user menu dropdown in this PR and make another PR for full page interface. thoughts on the mockup?
I’m not one with an eye for UX design, best to wait to hear from one of our designers.
I would start with the full notifications page PR first. Once that’s done, we can revisit the idea of adding the filters to the notification panel in the header.
We have some concerns that adding the filters to the notification panel in the header is unnecessary at this point.
Okay i will focus on that first, and will send you mockups of that page soon
Ooo I like it! Nicely done.
so is it final? May i start working on it?
Sure, but make sure you use select kit there and not a custom control
sure, ill use select kit
Ive used select kit and made a PR.
Ive completed this task and my pull request is merged.
One thing I noticed - it currently doesn’t pull all unread notifications. It only filters the first loaded ‘page’ of them, but if you have more unread ones in the past, you have to scroll down in the All view and only then switch to unread ones.
It would be fun if switching to Unread filter would load all unread notifications and not just the unread ones from the first page, if that makes sense
I’ve just found out another bug, I think.
When you middle click in this view:
It should open a topic in a new tab, but instead it clears the notification without opening any new tabs.
I’ll test it once again and will get back to you
Very excited to see this rolled out!
Thanks to everyone incubating this since January 2016
Started working on these changes will be submitted soon.