Null Login Bug? Last Couple Betas

bug
1

I believe this started the last couple beta downloads, but now after logging in “null” is added to the login which takes you to a 404.

To reproduce:
Login via any mechanism (I’ve tried both facebook and regular user login)
Logout
Login again and you will get loginmethod/null (previous beta it was no slash just loginmethodnull) - such as:
https://community.yinyanghouse.com/auth/facebook/null

You are actually logged in and everything works fine once you get away from the Oops not found page…

I’m assuming this is some sort of redirect that isn’t happening correctly, but just thought I would report…

2

Can you reproduce this on meta?

3

I hit this on try earlier today with Google. I was having some internet blips though, so I assumed it was that. Will see if I can repro.

Yep, consistent repro on try (can’t test here on Meta due to 2FA). I hit https://try.discourse.org/auth/google_oauth2/null after clicking “Log in”, then “Google”, then selecting my account. Login is successful, loading https://try.discourse.org/ directly after hitting the null page works.

5 Likes
4

I can’t seem to experience it on meta (but there I use my github account if that matters) - I can seem to get it everytime on my site https://community.yinyanghouse.com/ - at least with regular login and facebook…

Glad that someone else saw the error as well…

1 Like
5

Yes, it’s problem with that. When I login to my account (I used only login and password) i see result: http://mywebsite.comnull

image
image.png1046×405 11.4 KB

2 Likes
6

I can also reproduce this on try.discourse.org using GitHub login. FWIW, I couldn’t reproduce it using a regular signup/login.

3 Likes
7

@vinothkannans can you have an attempt to repro? I recall you recently changed some of the redirect back logic in the context of sso, maybe this is related

2 Likes
10

It’s fixed as per below commit. Clear the cookies and test the social login flow. It shouldn’t redirect back to the null URL again.

https://github.com/discourse/discourse/commit/08c404e138c5dfbb6e82ac7f6e54976d30b4530a

8 Likes