Post quote copy to clipboard button -- Feedback

This is a feedback topic for the design experiment to add a “Copy Quote” button to post quote buttons, which copies the quote markdown to clipboard:

Why add this button?

The normal Quote button that is shown when selecting text within a post will open the composer with the quote markdown prefilled:

This new “Copy Quote” button copies the quote markdown directly to the user’s clipboard. This is useful for when you want to copy the quote elsewhere – to another topic or a chat message for instance – without having to manually copy from the opened composer, which then has to be dismissed afterwards:

[quote="JammyDodger, post:7, topic:285376"]
Possibly a silly question, but what’s the difference between this button and the one I get normally?
[/quote]

This saves time for users who are constantly using quotes to reference information across multiple areas of the forum.

10 Likes

Note that this currently is broken, a PR is coming to fix this shortly:

2 Likes

I’m assuming the update would have been pulled here by now, the copy button does nothing when I click it.

2 Likes

It just worked for me, the deploy must have only just finished. Please refresh & try again :slight_smile:

2 Likes

Yep, works for me now.

2 Likes

Possibly a silly question, but what’s the difference between this button and the one I get normally?

4 Likes

If you’re referring to the top set of buttons, these are iOS-only, and would just copy the raw text to your clipboard. The Copy button next to Quote and Edit in this case copies the Discourse markdown of that quote, which looks like this:

[quote="JammyDodger, post:7, topic:285376"]
Possibly a silly question, but what’s the difference between this button and the one I get normally?
[/quote]

If you press Quote, then the composer opens with this prefilled, but a lot of the time you don’t want to quote the selected text in the current topic as a reply – you may want to quote it in another topic draft that you already have, or in chat.

5 Likes

I have always sub-consciously wanted this button.

:100:

I’m just noticing that the outcome feedback modal (i.e. “copied”) appears in the top right for some reason? Is that intentional? Just my initial gut would be that the feedback should appear in the same vicinity as the text popover buttons, i.e. where I just clicked.

5 Likes

Same. It’s also got me thinking, wouldn’t it be cool to have a search option too? Highlight a term or phrase, and then in one click be able to search it.

3 Likes

Maybe something similar to what happens when we use the (also an experiment IIRC) post URL copy :link: button?

image

6 Likes

Yeah, I like this suggestion. I do want to add though that this widget is getting large, the more buttons we add the harder it gets for users to use each of them. But we maybe it’s time to drop some buttons (looking at you “Share”) and/or organize them better.

Android has a Copy button as well. IIRC, we drop the “Share” button on iOS and Android for the same reason, because the OS provides close enough alternatives natively.

4 Likes

Yes I think @chapoi would prefer this too, she did this other copy button. I will hunt down the implementation of this and move the message to there.

The main difference is that, in the Copy button on quote, we hide the menu straight away, so hopefully this other message popup can stay where it is supposed to be when the underlying element disappears.

2 Likes

Exactly, I think this is a different situation than the copy-link.

Chat copy text also uses a toasty (altho copying chat text is limited to mobile use).

That being said: maybe this component should also be limited to mobile? Why would you use a click-action on desktop when ctrl-c is so ingrained?

1 Like

Because Ctrl-C does not add the quote format, but the new ‘Copy’ button does.

[quote="Charlie, post:14, topic:285376, username:chapoi"]
Why would you use a click-action on desktop when ctrl-c is so ingrained
[/quote]

I think the problem is that the button doesn’t explain its function clearly. It’s not obvious that it does something different than just copying. Now, on mobile, I have two copy buttons. It’s quite confusing to have two options and, each time, I have to think about which option is my desired action (I know the result I want, but I have to think about which button achieves that).

On mobile, for me, quoting and cutting the quote worked perfectly fine. On desktop, I usually do it as explained in the Discourse New User Guide.
I see how this might be helpful for heavy users, but for new users (and even not so new), it creates a lot of confusion.

4 Likes

Hmm, I see.

Perhaps a slightly more explicit can be the solution to make the distinction: “Copy quote”?

2 Likes

Moin also brought up the noise factor as part of "Enable quote reply for highlighted text" user setting

I think the addition of ‘Share’ for everyone and not just anon was a fairly recent decision - Change "share quote visibility" default from ANONYMOUS to ALL - #3 by tobiaseigen

2 Likes

Because we are living in the world where most of people don’t use keyboard shortcuts because they are using a mouse. Same thing as google is the most used way to give an url, not browsers itselves.

I did suggest this originally (Copy quote) internally but people thought it might be too long. However it is an experiment so I’ll just update it to that and see what people say.

1 Like

The double-menu situation makes things particularly difficult on mobile… the more we add there the more I start to wonder if we have to take a different approach than an additional pop-up (easier said than done).

Even without the additions, having two bars on text selection feels like a bad experience… 7 (or more) options spread across two menus is a lot to take in… and that’s before you start to wonder about the difference between “copy” and “copy quote”

4 Likes

You know all this, but

iPad:

iPhone:

It is a bit… overwhelming. Sure, muscle memory kicks in at some point, but at the moment I’m using wrong copy all the time.

5 Likes