Previous Replies separator is not RFC-compliant

rriemann · February 11, 2016, 4:36pm

Continuing the discussion from Imdb embeds broken on other sites:

I just received two mails with practically the same content (that’s weird) due to a response linked above and noticed:

My mail application KMail doesn’t strip off the signature when I reply. The issue seems to be the separator.

KMail claims that RFC compliant is -- (dash dash space on a single line).

I think I found the source: https://www.ietf.org/rfc/rfc3676.txt (4.3)

However, Discourse uses “—” (triple dash without space) as a separator.

github.com/discourse/discourse

lib/email/receiver.rb

cad7fc106


      
            try_to_encode(string, "UTF-8")
          end
          
          def try_to_encode(string, encoding)
            string.encode("UTF-8", encoding)
          rescue Encoding::InvalidByteSequenceError, Encoding::UndefinedConversionError
            nil
          end
          
          def previous_replies_regex
            @previous_replies_regex ||= /^---\n\*#{I18n.t("user_notifications.previous_discussion")}\*\n/im
          end
          
          def trim_discourse_markers(reply)
            reply.split(previous_replies_regex)[0]
          end
          
          def from
            @from ||= @mail[:from].address_list.addresses.first
          end

This issue has been raised before:

zogstrip · February 11, 2016, 5:49pm

I guess it doesn’t really matter since most people (except geeks) use HTML views

Topic		Replies	Views
[ is stripped from reply by email Support	5	591	May 17, 2018
Best practices: ascii separators in emails? Support	2	1118	August 13, 2020
Email signature not being stripped out when user write new topic or reply to a topic Support	40	3837	May 9, 2022
Return of the missing Yahoo HTML email stripping bug Bug	11	2663	July 21, 2022
Punctuation on a line causing stripping in plaintext mail Bug	4	746	December 13, 2017

Previous Replies separator is not RFC-compliant

Related topics