Return of the missing Yahoo HTML email stripping bug

Continuing the discussion from HTML email signature not being stripped out of notification reply:

https://meta.discourse.org/t/html-email-signature-not-being-stripped-out-of-notification-reply/21351?u=downey

It’s back, although now with extra email quoting inclusion as well. :slightly_smiling:

Yes this is for @zogstrip

Anyone who wants the original message source via Mess feel free to ping me.

1 Like

This should now be fixed for good :wink:

https://github.com/discourse/discourse/commit/46b6c55197a41e13c163f10e00138d78d6e79820

5 Likes

Or not… :frowning:

Can you send me the raw email?

Of course; check your messages. :wink:

1 Like

Looks like it’s working as expected here. (Except for the fact that we can’t properly identify user signatures and new lines, which are really hard problems)

Is there a preferred format for email signatures that is easily strippable by Discourse? If so we, could let our members know the format.

1 Like

Looks like this is optimized for stripping out Mobile signatures:

https://github.com/discourse/email_reply_trimmer/blob/master/lib/email_reply_trimmer/signature_matcher.rb

Our biggest offenders come from Desktop clients, for example:

In our case, we could gently encourage our users to proceed their signatures with something like: --------------------<line break> if that is acceptable.

Has this option already been considered: http://blog.mailgun.com/open-sourcing-our-email-signature-parsing-library/ ?

We have re-written our library over the years, it is indeed inspired by MailGun Talon and other libs.

I think this is fixed.

1 Like