Quick access to bookmarks and messages on user menu

xrav3nz · 10.Декабрь.2019 22:28:03

Took a quick look and opened a PR to fix this:

github.com/discourse/discourse

FIX: Always add username span in quick access item

master ← xrav3nz:empty-username-span

merged 10:44PM - 10 Dec 19 UTC

xrav3nz

+3 -1

> CONTEXT: https://meta.discourse.org/t/quick-access-to-bookmarks-and-messages-o…n-user-menu/32787/59 Generate an empty `<span>` even if there is no username, because the first `<span>` is styled differently: https://github.com/discourse/discourse/blob/505b8b76bce2023da6869a80d3d4c5a9ae340931/app/assets/stylesheets/common/base/menu-panel.scss#L178-L180 I am not sure if it would be better to add a CSS class instead. Open to suggestions, thanks! **Before** <img width="354" alt="Screen Shot 2019-12-10 at 2 09 11 PM" src="https://user-images.githubusercontent.com/6376558/70574321-b8387080-1b58-11ea-8113-f5de85eb087f.png"> **After** <img width="346" alt="Screen Shot 2019-12-10 at 2 10 20 PM" src="https://user-images.githubusercontent.com/6376558/70574324-b8387080-1b58-11ea-992b-36e8065ccf33.png"> ---

Тема		Ответов	Просм.
Quick Profile Links Menu Theme component	32	681	17.02.2026
Discourse Tab Bar for Mobile Theme component	78	21759	10.11.2025
Feedback on new :hamburger: and user menus UX	231	26185	15.07.2016
F NAV - Mobile Navigation Tabs Theme component mobile	72	1831	20.03.2026
Try out the new sidebar and notification menus! Announcements notifications , sidebar , new-feature	221	20811	19.10.2022

Quick access to bookmarks and messages on user menu

Связанные темы