Task Rake per unire utenti

[gerhard (Gerhard Schlager)]

A partire da Discourse 2.5.0.beta3, gli amministratori del sito possono unire utenti non appartenenti allo staff senza dover accedere alla console. Per motivi di sicurezza, gli utenti dello staff dovranno ancora essere uniti tramite la console.

Visita la pagina di amministrazione degli utenti e seleziona “Unisci” in fondo alla pagina.

Inserisci il nome utente in cui desideri unire l’account e clicca su “Trasferisci ed elimina @username” per avviare il processo di unione.

---

Il task rake per l’unione degli utenti è ora disponibile su tests-passed.

https://github.com/discourse/discourse/commit/7a2183e8ab97c26464da541014ba1f2e69669a82

Gli utenti possono essere uniti eseguendo:

rake users:merge['source_username','target_username']

(nota: assicurati che non ci siano spazi prima o dopo la virgola)

Questo comando unisce i dati dell’utente sorgente nell’utente target prima di eliminare l’utente sorgente. Vengono uniti i contenuti di 45 tabelle, quindi, a seconda della quantità di dati associati all’utente sorgente, questo processo potrebbe richiedere del tempo.

Gli autori di plugin possono agganciarsi al processo di unione gestendo l’evento :merging_users. L’ho già implementato per il plugin dei sondaggi, che unisce i voti dei due utenti uniti.

Problemi noti:

1. I collegamenti in entrata che fanno ancora riferimento all’utente sorgente (ad esempio https://talk.example.com/t/some-topic/17/3?u=source_username) non verranno associati all’utente target.

2. Un utente può avere un solo utente “ombra” (dalla funzionalità consenti pubblicazione anonima). Quindi, se entrambi gli utenti uniti avevano un utente ombra, quello posseduto dall’utente sorgente andrà perso… beh, è ancora lì, ma non è più associato a un utente esistente.

[mcwumbly (Dave McClure)]

@gerhard

It’s essentially based on my idea posted in Update quotes and mentions when username is changed.

Ooh… That’s the most exciting part of this to me.

[sam (Sam Saffron)]

We should try this out on some of the accounts at rubytalk.org … a great little test site, Matz has like 5 emails.

[mattbr]

Thank you for this feature, it is huge for my use case! I am currently porting our forums from phpBB to Discourse and wanted to use SSO via a custom provider. Since we could not easily link SSO accounts to our legacy accounts and works flawlessly!

If anyone else is going to use this make a note of this:

rake users:merge['mattbr_sso', 'mattbr_legacy'] will not work as expected, the SSO will not go through. However:

rake users:merge['mattbr_legacy', 'mattbr_sso'] works perfectly and allows you to migrate all the posts into the SSO account.

Thanks for the feature

[frictionel]

I’m super excited about this, but can’t see any mention of webhooks in this topic. Is this planned @gerhard?

[codinghorror (Jeff Atwood)]

How are webhooks relevant to this?

[frictionel]

When using the ‘User Event’-webhook created or login (or approved?) the duplicates will be existent on a connected site as well and one might want an automatism to clean them up as well, if the connected site supports that.

I haven’t used webhooks yet but plan to. On my connected site (using Discourse as SSO provider) the users are only created at first login for now.
+ I had duplicate users in my old forum before migrating to Discourse which I was looking forward to consolidate once this feature becomes available.

[JagWaugh (Andrew Waugh)]

I had another user question about this today, He also asked about the “Created” field in his profile.

1. Is this function going to be implemented in the GUI, or will it stay a rake task?
2. Will (or has) the rake task be(en) changed to handle mentions and quotes?
3. Would it be possible to set “Created” to the date of the oldest owned post?

[gerhard (Gerhard Schlager)]

@JagWaugh

Is this function going to be implemented in the GUI, or will it stay a rake task?

It will stay a rake task for now.

@JagWaugh

Will (or has) the rake task be(en) changed to handle mentions and quotes?

Yes, it will. I should be able to make this happen for the 2.0 release.

@JagWaugh

Would it be possible to set “Created” to the date of the oldest owned post?

You will have to update the user’s created_at manually if you want to set it to the oldest post. The merge process uses the created_at from either the source or target user – whatever date is earlier.

[barryvan (Barry van Oudtshoorn)]

@gerhard

It will stay a rake task for now.

This being the case, if as a hosted customer I have accounts to be merged, should I ping the details through to the Discourse team for actioning?

[codinghorror (Jeff Atwood)]

Sure that sounds fine. We also need to exercise the feature internally to make sure it is working right.

[gerhard (Gerhard Schlager)]

Quick update: Merging users now updates mentions, quotes and avatars in posts and revisions.

[tobiaseigen]

Any chance the staff action log could better show what happens to users when they are merged? Here’s how it looks now - just shows that system has deleted the user but no context. The details only show some info about the user that got deleted as a result of the merge.

[codinghorror (Jeff Atwood)]

Sure what do you think @gerhard?

[JagWaugh (Andrew Waugh)]

How about adding a staff note along the lines of “Username with email was merged to this account, date”

This is what I did when I was merging accounts manually. Probably more work than a staff action log entry, but might be useful information at some point later.

[codinghorror (Jeff Atwood)]

@gerhard we should make sure the task is logged in the staff logs if possible, per above ↑ ↑

[gerhard (Gerhard Schlager)]

I’m currently writing my todo list for this week and it’s already on it.

[pfaffman (Jay Pfaffman)]

Is there an easy way to change which email address is primary?

Here’s my use case:

imported user with email user@defunctdomain.com emails from user@fancynewemail.com which creates a staged user. After a few PMs with the staged user, I merge the accounts, but the primary address is still the old one. And from the web interface I can’t change the email in his profile because it’s already taken. By him.

Perhaps this is a bug in the multiple email address model and not a complaint for here.

The simple solution, which took me much to long to come up with, is to delete the old address.

[gerhard (Gerhard Schlager)]

Merging users always preserves the existing data of the target_user, so the email address of the source_user is only added as secondary email address.

@pfaffman

delete the old address.

Yeah, that’s the solution.

[pfaffman (Jay Pfaffman)]

Is there something easier that I should do?
I need to keep the old username with the new email. The staged user is the real problem. Perhaps I should just delete the staged user, but then I don’t have an easy way to reply to them to tell them what happened.

It’s pretty cumbersome to merge[‘newname_newemail’,'oldname_bogusemail"] and then have to do something like

u=User.find_by_username['oldname_bogusemail']
ue=UserEmail.where(user_id: u.id)
ue[0].destroy
ue[1].active=true
ue[1].save

is there some easier way that I’m missing?