Reset button and log look weird on mobile

Since some days, the upgrade Discourse admin upgrade page looks somewhat strange:

  • The “Reset Upgrade” button is wrapped in the next line.
  • The log area is only half the width of the available space.

My sceenshot is form a German iOS 11.3 on iPhone SE.

Maybe this can be improved?

4 Likes

Interesting, @Osama can you add to your list. (feel free to spin up a digital ocean instance to test this)

I think it is very legit to have a good “upgrade” UI on mobile.

5 Likes

This is a regression, so it needs to be fixed

1 Like

This looks like very related to screen size!

4 Likes

Ok, so I refactored a few things here and there and this is what I ended up with:

It should now be able to handle devices with extremely narrow screens (down to 320 pixels wide):

And on desktop:

Does this look good? anything out of place?

8 Likes

Looks good to me :panda_face:

6 Likes

PR sent :rocket:

5 Likes

Merged in, @uwe_keim let us know what you think

5 Likes

After reading this, I did one update and another one after that.

Still, it looks exactly the same as in my initial post.

Probably I have to wait some time until it is actually available in the official “branch”?

Where do you see the “Return to site” link? Is it one of the navigation tabs or above the discourse logo?

It is above the Discourse logo.

I’ll wait one more update, maybe it will then be fiex.

Looks good now:

4 Likes