Reset button and log look weird on mobile


(Uwe Keim) #1

Since some days, the upgrade Discourse admin upgrade page looks somewhat strange:

  • The “Reset Upgrade” button is wrapped in the next line.
  • The log area is only half the width of the available space.

My sceenshot is form a German iOS 11.3 on iPhone SE.

Maybe this can be improved?


(Sam Saffron) #2

Interesting, @Osama can you add to your list. (feel free to spin up a digital ocean instance to test this)

I think it is very legit to have a good “upgrade” UI on mobile.


(Jeff Atwood) #3

This is a regression, so it needs to be fixed


(Bhanu Sharma) #4

This looks like very related to screen size!


#5

Ok, so I refactored a few things here and there and this is what I ended up with:

It should now be able to handle devices with extremely narrow screens (down to 320 pixels wide):

And on desktop:

Does this look good? anything out of place?


(Sam Saffron) #11

Looks good to me :panda_face:


#12

PR sent :rocket:


(Sam Saffron) #13

Merged in, @uwe_keim let us know what you think


(Uwe Keim) #14

After reading this, I did one update and another one after that.

Still, it looks exactly the same as in my initial post.

Probably I have to wait some time until it is actually available in the official “branch”?


#15

Where do you see the “Return to site” link? Is it one of the navigation tabs or above the discourse logo?


(Uwe Keim) #16

It is above the Discourse logo.

I’ll wait one more update, maybe it will then be fiex.


(Uwe Keim) #17

Looks good now:


#18