Sam's Simple Theme

pmusaraj · January 6, 2021, 1:55pm

The category badges should be fixed now, too.

Alex_P · January 6, 2021, 2:09pm

The color of unread topics is a bit hard to read:

Default theme:

This theme:

Probably need to un-hardcode this:
https://github.com/discourse/discourse-simple-theme/blob/ce745784e99f57d19cdff7411f102260f3add303/desktop/desktop.scss#L10

Alex_P · May 13, 2021, 5:13pm

hm, looks like something is broken after recent update.

Now openning a topic from the list results in loading completely new page instead of just loading the topic with loading indicator etc. So it is a bit confusing because for a second it is unclear whether the click worked, and the editor window is lost, so it is difficult to add quotes from other topics etc.

Johani · May 13, 2021, 5:19pm

There was a bug related to this introduced a few days ago, but has since been fixed.

Can you please check if your site is on the latest?

/admin/upgrade

Alex_P · May 13, 2021, 5:21pm

oh, cool

Yeah, it is not latest
2.7.0.beta8 ( f002c58a30 )

Johani · May 13, 2021, 5:29pm

The fix for the bug I mentioned was added a couple of days after your most recent upgrade. Can you please try upgrading again and let me know if the issue persists?

Alex_P · May 14, 2021, 5:16am

Yeah, seems to work fine after upgrade.

I wonder though why this issue was occurring only in this theme, others had this auto-route thing too but somehow were working fine.

Alex_P · May 25, 2021, 3:52pm

Submitted a PR fixing this

github.com/discourse/discourse-simple-theme

Fix topic link color in dark mode

discourse:main ← programmersforum-reborn:fix-dark-scheme-link-color

opened 03:51PM - 25 May 21 UTC

AlexP11223

+6 -1

As shown [here](https://meta.discourse.org/t/sams-personal-minimal-topic-list-de…sign/23552/335?u=alex_p), dark blue link color is not very readable on dark background. So this PR adds a custom property in `color_definitions` switching to the color scheme primary color when in dark mode. We should keep the original color in light mode because it was one of the features of this theme.

jlzy · August 12, 2021, 5:08pm

Theme is significantly different in topic views since update… Please help!!!

awesomerobot · August 12, 2021, 5:29pm

can you be more specific about what has changed? do you have a screenshot?

jlzy · August 12, 2021, 10:07pm

Yes, here is what it looked like before the update:

Now it looks like this:

awesomerobot · August 13, 2021, 2:12pm

hmm that’s strange… the theme works fine here on Meta…

I don’t see any console errors on your site… did you edit the theme at all? if you install another copy of it does it have the same issue?

thisnthat · August 13, 2021, 3:06pm

A quick look shows that REFACTOR: Update structure, fix for ember-cli (#5) · discourse/discourse-simple-theme@0482a6c · GitHub may have changed the way that page is formatted on Aug 10th.

awesomerobot · August 13, 2021, 3:12pm

That refactored the theme structure, and fixed an issue with our ember-cli updates, but shouldn’t have changed anything about the layout (it’s also working as expected on our theme creator site: Discourse Theme Creator).

thisnthat · August 13, 2021, 3:28pm

I found the problem, looks like those changes conflicted with a component that was in place which resulted int he changes to the displayed format.

Thank you

Frully · November 21, 2021, 11:56pm

I’m running into a similar issue with most recent update - updated everything at once so not sure if it was theme, another component, or discourse itself:
Discourse 2.8.0.beta8
10a57825c8

Theme updated November 21 (can’t find version number) ‘up to date’.

Now, read, and unread all show as ‘unread’ secondary blue on desktop, but work correctly on mobile:
Desktop:

Mobile:

Same on various iterations of light, medium, dark schemes that we’ve made…the ‘categories+latest’ main page 2 column layout seems correct with brighter bold unread, and muted unbold read topics; but the ‘latest’ listing is all bold tertiary all the time.

Using preview on other themes (default, and others) seems to show the correct behaviour.

Alex_P · December 25, 2021, 10:30pm

Did you solve this issue?

The same for me, everything is shown like unread, other themes work fine.

Alex_P · December 26, 2021, 10:38am

Looking into DevTools, seems like this rule from app/assets/stylesheets/common/base/_topic-list.scss somehow disappears when using this theme

Alex_P · December 26, 2021, 3:01pm

ah, looks like topic-list-data is missing here.

github.com

discourse/discourse-simple-theme/blob/0482a6c24d49e5d35f338038f6fb1ac443e15709/javascripts/discourse/templates/list/topic-list-item.hbr#L11

    
      
          {{~raw-plugin-outlet name="topic-list-before-columns"}}
          
          
{{#if bulkSelectEnabled}}
            <td class="bulk-select">
              <label for="bulk-select-{{topic.id}}">
                <input type="checkbox" class="bulk-select" id="bulk-select-{{topic.id}}">
              </label>
            </td>
          {{/if}}
          
          
<td class='main-link clearfix'>
            {{~raw-plugin-outlet name="topic-list-before-status"}}
            {{raw "topic-status" topic=topic}}
            {{~topic-link topic class="raw-link raw-topic-link"}}
            {{~#if showTopicPostBadges}}
              {{~raw "topic-post-badges" unreadPosts=topic.unread_posts unseen=topic.unseen url=topic.lastUnreadUrl newDotText=newDotText}}
            {{~/if}}
            {{discourse-tags topic mode="list" tagsForUser=tagsForUser}}
            {{#if expandPinned}}
              {{raw "list/topic-excerpt" topic=topic}}
            {{/if}}

Submitted PR.

Frully · December 27, 2021, 2:49pm

I had not - thank you very much for looking into this

Topic		Replies	Views
Information Overload - Some insight through qualitative interviews ux	51	8765	November 6, 2015
Topic List Thumbnails theme-component official , topic-list-thumbnails	125	26743	February 5, 2024
Different theme for personal message topics list? dev personal-messages	21	365	February 14, 2024
MD Topic List component theme-component	63	8184	March 22, 2024
Redesigning the default category page ux	118	15287	April 18, 2017

Sam's Simple Theme

Related Topics