Slack integration issue with relative heading links

[debryc (Deborah Chang)]

Hi, I noticed an odd interaction with DiscoTOC and Slack integration. Basically the header links don’t properly post.

See details here

Set up Slack notifications using the discourse-chat-integration plugin

A really odd thing happens when chat-integration is paired with DiscoTOC - automatic table of contents (cc @Johani) The headings are now preceded by a link that does NOT go to the heading. See screenshots below. The original post [Screenshot of Google Chrome (4-4-21, 7-28-14 PM)] The preview in Slack [screenshot chat integration] Result of clicking on the first link is just the homepage of the forum [Screenshot of Google Chrome (4-4-21, 7-26-46 PM)]

[simon]

@debryc

I noticed an odd interaction with DiscoTOC and Slack integration. Basically the header links don’t properly post.

That is because the heading links do not include the path to the topic. For example <a name="overview" href="#overview">. The Chat Integration plugin is attempting to convert relative links into absolute links by prepending the forum’s root URL to any links in the post, but that is not going to work for the header links because the path to the topic is missing.

A possible solution would be for us to add the path to the topic to the TOC href element. For example, instead of setting <a name="overview" href="#overview">, the href element would be set to something like /t/your-topic-slug/1234#overview".

[OlliePartly (Ollie Chick)]

I find I get this when any post with headings are posted in Slack - the heading text is preceded by a link to the site homepage anchored with the headling name.

For example a post like this:

Comes through like this on Slack:

[awesomerobot (Kris)]

Yes it appears this is an issue with our automatic heading links, which exist even without the DiscoTOC theme component. I’ll update the title to reflect this.