SMTP User name does not save

[kgreed (kirsten greed)]

When I re run

./discourse-setup

the SMTP email becomes postmaster@discourse.mydomain.com
even though I previously entered myuser@mydomain.com

[codinghorror (Jeff Atwood)]

Can you reproduce this @pfaffman?

[pfaffman (Jay Pfaffman)]

Oh! @kgreed is correct! Apparently the “user the default mailgun username” code overrides the “use the pre-existing settings” code. I’m guessing that few people change their mailgun username, so this is an edge case.

Now that I think about it, the code that loads the defaults happens before the “oh! It’s mailgun, I know what to do” code. I’ll have a look and see if this is easy to fix.

[codinghorror (Jeff Atwood)]

Did this get fixed? Anything else to do here?

[pfaffman (Jay Pfaffman)]

It’s on my list,which has quite a few things on it now. I think that this one affects few people. It’s annoying, because you have to re-enter the value rather than have your old value used. It’s not quite a bug, because it does work.

I’ll try to submit a PR this week.

[tophee (Christoph)]

Same or related:

Minor glitch in discourse-setup

I noticed that when you run ./discourse-setup again after an initial run, it seems to remember the values entered during the previous run (i.e. email addresses, smtp password etc). But it does not remember the SMTP user name, worse even, it remembers it wrongly. It neither suggests the value that is actually in the app.yml nor does it resort to the default value (postmaster@discourse.example.com). Instead it seems to construct the suggested address by combining postmaster@ with the forum’s doma…

[pfaffman (Jay Pfaffman)]

Here, ya go.

FIX discourse-setup--better sanity checking