Thanks for the new version, which brings better integration with Category Icons. There are some issues though:
If icon color is set in the Category Icons TC and the banner color in Category Banners is set to the same color, the icon in the banner title becomes ‘invisible’
New flex CSS style on the icon breaks long category names with icons on narrow viewports (mobile view)
Category with subcategories doesn’t show banner on landing, shows banner after refresh
but it would be even better if this could be overriden directly in the TC. Maybe a new setting set category icon color which would be enabled when show category icon is checked.
Second one is trickier, I’ve tried overriding it with CSS without consistent results, perhaps this will need a redesign on the structural level (I believe the icon element was previously in a separate div, but is now included inside h1)?
Great feedback, thanks! I’ve just merged an update to how the icon is aligned and added a setting that will override the category icon color when it’s enabled. This also requires an update to the category icons component (I needed to add a class name to adjust the layout), so make sure to update that as well.
No, this only happens when directly visiting a category which has subcategories.
Edit: this only happens when opening such category directly from /categories view. When using a category drop down to select a category the banner is displayed correctly.
i installed this and have reproduced the error. in a category with a subcategory, i have clicked on the header breadcrumb and when you go to the category the header box is there but not the category banner.
ok there are two ways the banner doesn’t show up - from category page (i am running topic author component). it works for sub-categories but not categories. it also happens from the topic header breadcrumb in a topic.
I think I found the cause: in the top category settings set Default List Filter from all topics to no subcategories and refresh, then you’ll be able to reproduce.
@Lilly do you have the same no subcategories set by any chance?