Tags from multiple tag groups required only suggest "select at least one tag"

sterretje · May 4, 2023, 12:45pm

Apologies if this was reported before; I did not find relevant topics but my search skills are not always up to scratch.

I have the following configuration for a category

Minimum number of tags required in a topic: 2
Restrict these tag groups to this category: a whole stack of groups
Require new topics to have tags from tag groups:a single group, also present in (2)

Result when starting a topic; expected it to state that at least two tags are required.

Attempting to submit the topic with a single tag results in

saquetim · May 15, 2023, 8:39pm

This issue should be resolved in

github.com/discourse/discourse

FIX: Miscellaneous tagging errors

discourse:main ← discourse:fix/misc-tagging-bugs

opened 07:45PM - 10 May 23 UTC

megothss

+868 -39

# FIX: Displaying the wrong number of minimum tags in the composer When the m…inimum number of tags set for the category is larger than the minimum number of tags set in the category tag-groups, the composer was displaying the wrong value. This commit fixes the value displayed in the composer to show the max value between the required for the category and the tag-groups set for the category. This bug was reported on Meta in https://meta.discourse.org/t/tags-from-multiple-tag-groups-required-only-suggest-select-at-least-one-tag/263817 # FIX: Limiting tags to categories not working as expected When a category was restricted to a tag group A, which was set to only allow one tag from the group per topic, selecting a tag belonging only to A returned other tags from A that also belonged to other group/s (if any). Example: Tag group A: alpha, beta, gamma, epsilon, delta Tag group B: alpha, beta, gamma Both tag groups set to only allow one tag from the group per topic. If Category 1 was set to only allow tags from the tag group A, and the first tag selected was epsilon, then, because they also belonged to tag group B, the tags alpha, beta, and gamma were still returned as valid options when they should not be. This commit ensures that once a tag from a tag group that restricts its tags to one per topic is selected, no other tag from this group is returned. This bug was reported on Meta in https://meta.discourse.org/t/limiting-tags-to-categories-not-working-as-expected/263143. # FIX: Moving topics does not prompt to add required tag for new category When a topic was moved from a category to another, the tag requirements of the new category were not being checked. This allowed a topic to be created and moved to a category: - that limited the tags to a tag group, with the topic containing tags not allowed. - that required n tags from a tag group, with the topic not containing the required tags. This bug was reported on Meta in https://meta.discourse.org/t/moving-tagged-topics-does-not-prompt-to-add-required-tag-for-new-category/264138. # FIX: Editing topics with tag groups from parents allows incorrect tagging When there was a combination between parent tags defined in a tag group set to allow only one tag from the group per topic, and other tag groups relying on this restriction to combine the children tag types with the parent tag, editing a topic could allow the user to insert an invalid combination of these tags. Example: Automakers tag group: landhover, toyota - group set to limit one tag from the group per topic Toyota models group: land-cruiser, hilux, corolla Landhover models group: evoque, defender, discovery If a topic was initially setup with the tags toyota, land-cruiser it was possible to edit it removing the tag toyota and adding the tag landhover and other landhover model tag like evoque for example. In this case the topic would end up with the tags toyota, land-cruiser, landhover, evoque because Discourse will automatically insert the missing parent tag toyota when it detects the tag land-cruiser. This combination of tags would violate the restriction specified in the Automakers tag group resulting in an invalid combination of tags. This commit enforces that the "one tag from the group per topic" restriction is verified before updating the topic tags and also make sure the verification check the compatibility of parent tags that would be automatically inserted. After the changes the user will receive an error similar to: The tags land-cruiser, landhover cannot be used simultaneously. Please include only one of them. This bug was reported on Meta in https://meta.discourse.org/t/editing-topics-with-tag-groups-from-parents-allows-incorrect-tagging/263968.

sterretje · May 16, 2023, 9:45am

This issue is resolved

Topic		Replies	Views
Moving tagged topics does not prompt to add required tag for new category Bug tags	7	524	May 16, 2023
Editing topics with tag groups from parents allows incorrect tagging Bug tags	3	520	May 16, 2023
Limiting tags to categories not working as expected Bug tags	9	755	May 24, 2023
You must select at least 1 tag - even though one was created Bug	6	1637	October 27, 2021
The category setting for tags is not respected Bug	0	485	February 26, 2021

Tags from multiple tag groups required only suggest "select at least one tag"

Related topics