Thumbs up, twice

nat · October 28, 2022, 11:36am

Fix here. Should be in soon!

github.com/discourse/discourse

FIX: Evaluate all callbacks rather than override them

discourse:main ← discourse:multiple-post-menu-button-callbacks

opened 11:32AM - 28 Oct 22 UTC

nattsw

+33 -20

When we have multiple plugins triggering ``` api.removePostMenuButton("like"…, () => x); ``` the last plugin that makes the call gets to decide if the post menu button is removed or not. This change makes it such that we will evaluate all callbacks rather than just rely on the last one. Essentially, we ended up with duplicate like buttons when the discourse-upvotes plugin evaluates after discourse-reactions. <img width="354" alt="Screenshot 2022-10-28 at 7 33 19 PM" src="https://user-images.githubusercontent.com/1555215/198577684-add9e90d-7523-4595-8680-216add1cfe84.png"> Related: https://meta.discourse.org/t/thumbs-up-twice/240867/

Topic		Replies	Views
Post Voting has likes enabled but they won't appear bug reactions , post-voting	10	1018	August 14, 2023
Changes to which reactions :thumbsup: are counted as likes :heart: announcements reactions	45	1710	May 16, 2024
Notice: testing Discourse Reactions here on meta for 1 week! feature	87	6600	May 30, 2021
People are not using the :heart: button community	34	7015	June 25, 2018
Thumbs-up - three names, one emoji ux reactions	12	1062	September 11, 2023

Thumbs up, twice

Related Topics