Tiny positioning issue with the table editor fullscreen button

UX
1

Pasted image 20240621191523
Pasted image 20240621191523188×109 1.69 KB

How to reproduce:

A side-effect of UX: improve mobile table editor button location by awesomerobot · Pull Request #25426 · discourse/discourse · GitHub.

The no-text class has been removed for the fullscreen button since it doesn’t have a label, so a margin appears.

The image shows a snippet of code with line numbers, where one line has a deletion marked with a minus sign, another line has an addition marked with a plus sign, and there are references to "btn-icon", "no-text", and what appears to be a React component prop related to "no-text". (Captioned by AI)
The image shows a snippet of code with line numbers, where one line has a deletion marked with a minus sign, another line has an addition marked with a plus sign, and there are references to "btn-icon", "no-text", and what appears to be a React component prop related to "no-text". (Captioned by AI)550×109 2.99 KB

It’s unclear if the condition is inversed or if the intent was to reduce the space between the icon and the text. :smile:

2 Likes