merefield
November 26, 2020, 9:24am
1382
I don’t know, what I noticed is that the excerpt field from the JSON payload doesn’t have links stripped out.
Plus, the Topic List Previews plugin author, @merefield , also had some issues with excerpts with links recently: Excerpts are being poisoned by onebox URL's on Post Rebuild
EDIT: You’re right @awesomerobot , this is a specific issue with the Topic List Previews. I just disabled it on my instance and the issue is gone, it looks like TLP is overriding the default excerpt serializer becaus…
@renato , @falco I don’t believe this is a TLP bug.
To prove my point, rebuild an OP which contains a link and check the excerpt (without TLP installed). Use the excerpts Theme Component, for example
e.g.:
As you can see, the excerpt is polluted with a link. There is no TLP involved in the above.
However, I created a a workaround for this, and an option to exclude the links in settings:
https://github.com/merefield/discourse-topic-previews/commit/bdd7ba0baeb1bafc06658379a15affc0e861b7fd
This is only implemented in the TLP TC based setup, I’ve not backported this to the main plugin. I tend to focus on putting new features into the TC. Also no point in proliferating if this gets fixed in Core?
2 Likes
