Hi, I checked latest both stable 1.9.3+2
and test-passed
and realized that custom badge cannot be granted to user if the reason field is not empty.
Steps to reproduce:
create a new simple badge using font-awasome icon, without SQL
go to admin/users, find desirable user
click Edit badges
select the badge created
type a reason (important!) https://www.cuba-platform.com/discuss/t/redirecting-http-to-https/3977/4
click Grant
you’ll get an error, see details below in the picture.
If the reason field is empty, there is no error.
My forum is in a subfolder, probably that’s a reason of the fail:
2 Likes
sam
(Sam Saffron)
March 7, 2018, 1:50am
2
This looks incredibly likely to be the reason, unable to repro on non-subfolder.
4 Likes
saurabhp
(Saurabh Patel)
December 31, 2018, 8:10am
3
Hi,
I was able to find the issue. I found it out after seeing that we were returning 404 in the first screenshot instead of 400. We were not taking care of relative_root_url while parsing reason of badge.
I have created PR for the same here:
https://github.com/discourse/discourse/pull/6836
7 Likes
tgxworld
(Alan Tan)
January 11, 2019, 7:00am
4
This has been merged. Thank you @saurabhp !
4 Likes
tgxworld
(Alan Tan)
Closed
January 14, 2019, 10:00am
5
This topic was automatically closed after 3 days. New replies are no longer allowed.