Votes not being released after close

AI-generated summary

Users reported an issue where votes were not being returned to users after topics were closed, despite the expected behavior that closing a topic should free up votes for reuse. JohnONolan observed that even with closed topics, users remained out of votes. plentymarkets_david confirmed the issue persisted in their test instance using Discourse v2.1.0-dirty and the latest voting plugin, though later noted that applying recent updates appeared to resolve it. kspearrin asked if simply closing topics (without moving categories) would work, and sam encouraged testing. featheredtoast clarified that the bug was about vote reclamation, not notifications. However, kspearrin tested again on v2.2.0.beta2 +5 and found votes still weren’t reclaimed after reopening and reclosing topics. sam closed the topic, citing that OsamaSayegh had previously fixed the internal implementation years ago, and invited users to reopen or create a new topic if issues persist.

Are there any known issues with this? It doesn’t seem to be working for us:

  • I’m out of votes with a limit of 10, but only voted on 9 things here
  • The two highlighted topics are both closed, but still appear on my votes page / I’m still out of votes

Sounds similar to: Closed topics not returning votes to users - but the fix there was about moving topics between categories // which doesn’t apply here?

7 Likes

Hi guys

I can confirm that the issue is not fixed that I also originally reported here:

We tested this on a test instance with discourse v.2.1.0-dirty with the latest version of the voting plugin including the fix by OsamaSayegh.

Neither moving the topic to category with voting disabled nor closing the post will release the votes.

5 Likes

Actually nevermind. We just took the latest changes posted 12 days ago and it seems to be working. Sorry for the quick shots. Note: the current PR is still open, will it be reviewed any time soon?

3 Likes

Does it work if just closing now? We don’t want to move the topic to another category.

1 Like

I think it should, can you give it a shot?

3 Likes

hii i’m a discourse newbie - can i gather from this thread that when a vote is closed, anyone who voted should be notified of the results?

That’s not what it means. You have a certain amount of votes that you can use at any given time, which should be reclaimed after a vote (you can vote on more things after old voting topics close). It wasn’t happening, and now it is. That is the bug being discussed.

4 Likes

@sam @featheredtoast

I just tested this using v2.2.0.beta2 +5. I re-opened and re-closed a couple of topics that were previously closed with votes (when the bug was first occurring). After doing this, users that had voted in those topics report that they are still not able to vote because their previous votes were not reclaimed.

1 Like

So sorry, closing this as @Osama repaired the internal implementation a few years ago.

If there are any open issues with this please flag to reopen, or create a new topic.

4 Likes