Whispers Break Frequent Posters' Post Count

Thanks @zogstrip for fixing the whispers showing up in frequent posters.

I noticed the fix breaks the numbers of posts above each user’s avatar. They appear with no numbers whenever there is a whisper present in the topic. When no whisper exists the numbers appear at the upper right corner of the avatar as before.

Is there an easy fix for this? I doubt anyone would mind this being left as a known issue if not. Again looks pretty good.

https://github.com/discourse/discourse/commit/0096ee40da5b848a2db2f5ecbfefd07ef494f934

1 Like

Hmm, having a look :thinking:

Here’s a wisper post with no post count numbers.

1 Like

Actually, that is because we only show the post count when it’s > 2.

So no :bug: here.

It seems Whispers can be exposed via the “Filter” option on a User’s Usercard

And shouldn’t there be a post count of codinghorror’s user, since he has 2 public replies?

2 Likes

I’ll see if I can fix the count on the user card.

I said > 2, not >= 2 :wink:

2 Likes

The leak on the user card is now fixed :sweat_drops:

https://github.com/discourse/discourse/commit/797936d2c5839f1c2a5dd8effe130e87261cd15d

4 Likes