Unable to grant custom badge for non-empty reason field

Contribute Bug

AI-generated summary

A user reported an issue with granting custom badges when the reason field is not empty Ivan_Rapekas. The problem was suspected to be related to the forum being in a subfolder. However, saurabhp identified the root cause as the failure to account for relative_root_url while parsing the badge reason. A pull request was created to fix the issue, which has since been merged tgxworld, resolving the problem.

1

Hi, I checked latest both stable 1.9.3+2 and test-passed and realized that custom badge cannot be granted to user if the reason field is not empty.

Steps to reproduce:

  1. create a new simple badge using font-awasome icon, without SQL
  2. go to admin/users, find desirable user
  3. click Edit badges
  4. select the badge created
  5. type a reason (important!) https://www.cuba-platform.com/discuss/t/redirecting-http-to-https/3977/4
  6. click Grant
  7. you’ll get an error, see details below in the picture.

If the reason field is empty, there is no error.

My forum is in a subfolder, probably that’s a reason of the fail:

image
image1367×715 126 KB

2 Likes
2

This looks incredibly likely to be the reason, unable to repro on non-subfolder.

4 Likes
3

Hi,
I was able to find the issue. I found it out after seeing that we were returning 404 in the first screenshot instead of 400. We were not taking care of relative_root_url while parsing reason of badge.

I have created PR for the same here:
https://github.com/discourse/discourse/pull/6836

7 Likes
4

This has been merged. Thank you @saurabhp!

4 Likes
5

This topic was automatically closed after 3 days. New replies are no longer allowed.