Cancelling "Edit Category" screen changes "Following" status

Bug
1

Edit a category and then cancel immediately.
If you followed category before editing, it will now show you aren’t following anymore.

wyw9a5524.gif986×1182 2.25 MB

1 Like
2

notification_level is unset when the category object is serialized and transferred to the browser. Setting it in categories_controller.rb fixes the issue. Like so.

def show
    if Category.topic_create_allowed(guardian).where(id: @category.id).exists?
      @category.permission = CategoryGroup.permission_types[:full]
    end

-> @category.notification_level = CategoryUser.where(category: @category.id).first.notification_level**

    render_serialized(@category, CategorySerializer)`
end

@sam?

3

Perhaps submit a PR to fix?

4

Sure. just got a bit nervous being a first timer.

1 Like
5

I’m reporting issues with pleasure, but unfortunately not able to fix them as I do not run dev instance of Discourse locally.

3 Likes
6

Fixed with:
https://github.com/discourse/discourse/pull/3911
thanks @tgxworld.

3 Likes
7

This topic was automatically closed after 2 days. New replies are no longer allowed.