Changing js.browser_update text doesn't apply on no JS views

Support
1

  1. Change js.browser_update in Customise > Text.

  2. Open Discourse in IE10

  3. Default message is shown instead of customised one

2

AFAIK JS text customizations run in Javascript. Since our mode for old browsers is plain HTML without Javascript, anything JS won’t run in there. This behavior is expected.

1 Like
3

It’s set here. https://github.com/discourse/discourse/blob/master/vendor/assets/javascripts/browser-update.js.erb#L29

So it should be applicable. :man_shrugging:

1 Like
4

Oh, that won’t work anymore as we are removing all globals, with I18n being the one that was removed last week.

It may work after a rebuild @zcuric.

3 Likes
5

Not working unfortunately. We did a release today and rebuild the app, same thing.

6

I have the same problem. I thought when I first changed js.browser_update it did display on an old browser (but I’m not 100% sure now), but today I see that it shows the original text. Is there any way round this… maybe treating this particular message differently, as mostly when this message is displayed Javascript won’t be on? Maybe a short plugin?

7

The reason you saw this work on one browser, and then not on another, might be because some really old browsers can’t support the client-side translation, while others can.

We first try to run the translation, and if it doesn’t work, we fall back to a hard-coded instance of the default message in English:

Unfortunately there’s not much more we can do about this. Hopefully people will be off those browsers at some point.