Db/fixtures/006_badges.rb has outdated FA icons

pfaffman · December 4, 2024, 9:11pm

Not sure where to put this since it’s not actually a bug yet.

On a just-updated site I get a bunch of warnings about outdated fa icons.

It looks like they are all in db/fixtures/006_badges.rb.

discourse/discourse/blob/main/db/fixtures/006_badges.rb#L159


      
          end
          
          [
            [Badge::Promoter, "Promoter", BadgeType::Bronze, 1, 0],
            [Badge::Campaigner, "Campaigner", BadgeType::Silver, 3, 1],
            [Badge::Champion, "Champion", BadgeType::Gold, 5, 2],
          ].each do |id, name, type, count, trust_level|
            Badge.seed do |b|
              b.id = id
              b.name = name
              b.default_icon = "fa-user-plus"
              b.badge_type_id = type
              b.multiple_grant = false
              b.target_posts = false
              b.show_posts = false
              b.query = BadgeQueries.invite_badge(count, trust_level)
              b.default_badge_grouping_id = BadgeGrouping::Community
              # daily is good enough
              b.trigger = Badge::Trigger::None
              b.auto_revoke = true
              b.system = true

kelv · December 5, 2024, 7:22am

Thanks @pfaffman for the report! I’ve removed those from the badges fixtures as part of DEV: update more deprecated font awesome icon names by tyb-talks · Pull Request #30123 · discourse/discourse · GitHub.

joffreyjaffeux · December 10, 2024, 9:50am

This topic was automatically closed 5 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Default badge icons UX completed	4	1170	March 8, 2023
Fa-icons and badges - some work, some don't Support	2	1027	September 3, 2019
Versatile Banner: Icons disappeared with latest updates Bug versatile-banner	7	485	September 21, 2023
Finding FA icon deprecation Support	5	537	March 23, 2020
replaceIcon() not replacing the user menu dropdown's icon Support	1	18	November 22, 2024

Db/fixtures/006_badges.rb has outdated FA icons

Related topics