Hamburger Theme Selector

theme-component

(Jeff Atwood) #12

There is no concept of per-user theming without being logged in, since there is no user in the anonymous case. So the bug is that it should only show up for logged in users.


(Republic Wireless) #13

OK, that make sense.

This text might need changing then:


(Jeff Atwood) #14

Hmm yeah I have no idea how this would work with anon users, @sam will have to answer that. Maybe he had some weirdo cookie hack in before for site-wide themes or something.


(Sam Saffron) #15

It should work with anon I just need to fiddle with it a bit, the cookie keeps track of the theme


(Sam Saffron) #16

A 4 letter regression in core is now fixed :wink:

Will deploy republic later today @Sean_R


#17

The selector still only works with logged in users… Is it still broken or am I doing something wrong?


(Sam Saffron) #18

Great catch, this is fixed now in latest, it was a bug in core. I will backport it to stable.


(Nigel Tatschner) #19

Hi All,

I’m being stupid, I’ve added this via the template upload function and it appears in the list but it’s not working.

Please help, i’m being special.


#20

After you import the Hamburger Theme Selector you need to add the Hamburger Theme Selector as a Theme Component.


(Yegor) #21

Hi guys!

Our themes do not appear in the hamburger menu, so the users (and the admin aswell) cannot switch between themes. What could be wrong?


(Sam Saffron) #22

Are you on latest, are the themes user selectable?


(Yegor) #23

There is a checkbox saying “Theme can be selected by users”. So I assume yes.

Thanks for the quick answer.


(Yegor) #24

so any thoughts, Sam? :slight_smile:


(Jeff Wong) #25

Can you confirm that you have done this?

The way I understand it is you’re going to need the hamburger theme selector added as a Theme Component for all of your other existing themes for it to appear. Add the hamburger theme to all of the others via the Theme includes other child themes option.


#26

this is such a useful extension. Please consider including this as a part of Discourse’ core.


(Erlend Sogge Heggen) #27

Related:


#28

Just an FYI for everyone … recent 2.1 Beta update broke the existing Hamburger Theme Selector installations. It simply took an update of the HTS to fix this from within its Theme component admin. (so seems someone knew about this, aha! :wink: (@Sam would have been good to have a heads up, sorry if I missed it) ) (there seems however to be a new issue with Themes admin, see my ‘bug’ report)


Missing options on themes
(Alex Sherwood) #29

Just a minor suggestion - it might be worth adding a ‘Themes’ header to that section of the menu to help users figure out what those are. Where I’ve added the red box -

16ada34132c54804afa4a728b711bda1bffe8c25


#30

The theme-selector seems to be broken in v2.2.0.beta4 +266.

TypeError: e.reject is not a function
    at Object.a [as setLocalTheme] (_application-0886f4c5dbc868ca081df73f2ba68777febbad4e17b4e00dc8cb7aa447d11a4d.js:21312)
    at 0c56ef81d321af57aa11e5f7762b891635ccf8ce.js?__ws=www.elektronauts.com:16
    at A (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:57655)
    at S (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:57670)
    at C (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:57638)
    at invokeWithOnError (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:12552)
    at a.flush (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:12613)
    at u.flush (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:12737)
    at p.end (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:12807)
    at p.run (_ember_jquery-07f49b58317ea9292d939348ec0091eb50a9d8aaabd9e86cc074ef5f049918aa.js:12921)

happens in

themeSelector.setLocalTheme(key, r.user.user_option.theme_key_seq);

Any ideas?

/David


(David Taylor) #31

It works ok for me - I’m using it right now on this site!

Can you reproduce the problem here? If so, what browser are you using?