Long term whisper posts on topics?


(Dean Taylor) #1

There has been a couple of topics stopping me from getting to Unread inbox zero…

There are a couple of topics above which are standing between me and :unicorn:

I just wanted to check it is “whisper” posts at the ends of these topics that causing me to unable to “read” these completely and not a “bug”?

https://meta.discourse.org/t/sharing-image-posted-on-discourse-to-facebook-didnt-display-a-thumbnail/37171/10?u=deanmarktaylor&source_topic_id=45057

(Sam Saffron) #2

Deleted 2 whispers…

I do want to solve this, but it is very tricky cause we would need to carry around 2 tracking states per topic and amend a pile of queries.


(Dean Taylor) #3

Just wanted to make sure it wasn’t part of some other bug…
… I was noticing odd Unread counts - I assume this was whisper posts at the ends of topics coming and going.


(Mittineague) #4

The easiest work-around is to go to Unread, and when you’re sure you have read (all that you can) Dismiss the topics.

I’ve been doing it for a long time now and it does work.


(Dean Taylor) #5

I was aiming for checking there wasn’t bug in the topic / post reading logic.


However this might actually be considered a bug…

I consider “dismiss” a “dangerous” operation from a users reading point of view…

In so far as you can “dismiss” topics you haven’t seen yet.

Topics or posts have been created in the between loading the list of unread topics and confirming the dismiss can be incorrectly dismissed.

Yes, possibly a small window - but with users leaving browser windows open for days now - it might be bigger than you first think.

In the same way as a delete operation takes the exact topic / post ID’s and passes those to the server “dismiss” should so the same…
… only dismissing those topics that were in the view when the user selected “dismiss”.

Currently it just passes:

So no ID’s - meaning - everything is dismissed regardless of if the user was aware of it or not.


(cpradio) #6

Actually there is already support for this. topic_ids can be passed with the dataset, per

However, only Staff have the ability to select topics using the selection tool menu thing on the topic listings. Might be worth opening up that ability to all users? (which may be a feature request)

Here is the two related form datas (using the topic selection tool, then without said topic selection tool).


(Dean Taylor) #7

API level support is great … but to be clear - even “dismiss all” should pass the ID’s.

And really to be absolutely sure you are dismissing the right state, both the topic ID and post ID of a topic should be passed.
Your view of the last known poster may impact your decision to dismiss.


(Mittineague) #8

Hmmm that gives me a thought.

I can’t test it now as of the last upgrade my dev set up is broken.

But next time it happens I’ll try it. i.e.

Dismiss, then revisit the topic and Track / Watch it.

That is, will Dismiss “move” the “last seen” to include the whisper post.


(Mittineague) #9

I was getting the persistent unread for this topic (I Watch the plugin category)

I Dismissed it.

When I went back to the topic I was still Watching it.
Dismissing the unread did not reset my Watch


(Sam Saffron) #10

This is now fixed per:

https://github.com/discourse/discourse/commit/33d0a23d84a4d22f28b33a44df67dee1d14c35a0

Whispers are no longer an “experimental” feature.

There are a few notes though:

If you have an old system where you had “experimental whispers” enabled and were using them make sure you run:

./launcher enter app
rails c
Topic.reset_all_highest!

There is an edge case I will work on fixing where unread counts are higher than what they really are. In particular, if there is a whisper (or deleted post) between your old highest read post number and last visible post number on topic. I have an idea on how to fix but it is not a show stopper.


Whispers on community - users get a notification
Cannot get this topic out of my unread list due to whispers
Whisper posts generate unread badges and show on user profile/topic list (last poster)
Whispered replies leak in the reply count
Unread old post bug?
Persistent unread post for certain topics
Topics shows as unread indefenetly if last post is made in whisper
"USER split this topic" makes topic forever "un-visited"
(Sam Saffron) #11