Problem with api version when updating docker manager

HeroHabit · January 13, 2024, 9:39pm

Hello,
I am having an issue with MY FORUM where it’s just continuously loading. I did update the docker today and that seems to be what is causing the issue but I don’t know if/how I can revert that. I’m able to access the site in safe mode and have disabled all plugins, elements, and themes but it still won’t load out of safe mode. Any guidance would be appreciated. Thanks!

JammyDodger · January 13, 2024, 9:55pm

I think I’ve hit this as well. I updated docker manager through the UI and afterwards my site wouldn’t load. It loads in safe mode with no plugins (I only have official ones), but then I don’t have docker manager to run the main update of Discourse itself.

I’m currently doing a ./launcher rebuild app from the command line and I’m hoping that sorts it.

Don · January 13, 2024, 10:05pm

Hello

I think this happens here:

The Plugin Api version changed here to 1.24.0

github.com

discourse/discourse/blob/731699a7cfcfdd317c5ce08a21dbf4cf020bbc8d/app/assets/javascripts/discourse/app/lib/plugin-api.js#L149


      
            replaceIcon,
          } from "discourse-common/lib/icon-library";
          import { CUSTOM_USER_SEARCH_OPTIONS } from "select-kit/components/user-chooser";
          import { modifySelectKit } from "select-kit/mixins/plugin-api";
          
          // If you add any methods to the API ensure you bump up the version number
          // based on Semantic Versioning 2.0.0. Please update the changelog at
          // docs/CHANGELOG-JAVASCRIPT-PLUGIN-API.md whenever you change the version
          // using the format described at https://keepachangelog.com/en/1.0.0/.
          
          export const PLUGIN_API_VERSION = "1.24.0";
          
          // This helper prevents us from applying the same `modifyClass` over and over in test mode.
          function canModify(klass, type, resolverName, changes) {
            if (!changes.pluginId) {
              // eslint-disable-next-line no-console
              console.warn(
                consolePrefix(),
                "To prevent errors in tests, add a `pluginId` key to your `modifyClass` call. This will ensure the modification is only applied once."
              );
              return true;

And the recent update in Docker Manager is use this plugin api version.

github.com

discourse/docker_manager/blob/5a0499af2911bcda043c613cbf7048158114725b/admin/assets/javascripts/discourse/initializers/admin-sidebar-upgrade.js#L8


      
          import { withPluginApi } from "discourse/lib/plugin-api";
          
          export default {
            name: "docker-manager-admin-sidebar",
            before: "admin-sidebar-initializer",
          
            initialize() {
              withPluginApi("1.24.0", (api) => {
                api.addAdminSidebarSectionLink("root", {
                  name: "admin_upgrade",
                  route: "upgrade.index",
                  label: "admin.docker.upgrade_tab",
                  icon: "rocket",
                });
              });
            },
          };

So you have to update Discourse too because Docker Manager use plugin api version which higher than Discourse used plugin api version before update and Docker Manager will break.

The problem with this in admin you can only update first Docker Manager so rebuild required in this case.

HeroHabit · January 13, 2024, 10:24pm

Pardon my ignorance but will I lose all my forum posts if I do a rebuild?

JammyDodger · January 13, 2024, 10:30pm

No, your data will be left alone. You can read more detail about it in this topic:

HeroHabit · January 13, 2024, 10:35pm

Thanks. As soon as I posted that I thought, “I’ve done a rebuild a bunch of times”! but figured I’d let it stay in case someone in the future needs this topic. Rebuild is running now, hope that settles it. I don’t have an active forum (yet) but it does get a fair amount of traffic so I hate the down time. Thank you for your help!

EchoBilisim · January 14, 2024, 9:13pm

Hello, I have followed all the commands here, but my site still appears to be loading, but the site does not open.

JammyDodger · January 14, 2024, 9:18pm

Are you using the stable branch rather than tests-passed? If so, I believe Don has just shared a workaround that might be useful until a fix is in place:

martin · January 15, 2024, 1:01am

My apologies everyone, I must have overlooked something as part of my testing for this change. I have reverted it here, that should solve the issue:

JammyDodger · January 15, 2024, 7:27pm

2 posts were merged into an existing topic: Page keeps loading after update

sam · January 15, 2024, 9:00pm

This topic was automatically closed after 15 hours. New replies are no longer allowed.

Topic		Replies	Views
After upgrade, unable to go in discourse Support	9	494	February 14, 2024
Discourse not loading after update Installation	3	443	January 14, 2024
Blank upgrade page afer upgrading docker manager Bug	12	1273	July 9, 2020
Attempted to upgrade and I think I messed something up Installation	12	870	December 20, 2022
Site crashed - what are my options Installation	18	514	May 18, 2023

Problem with api version when updating docker manager

Related Topics