Sam's Simple Theme

Yes, here is what it looked like before the update:

Now it looks like this:

1 Like

hmm that’s strange… the theme works fine here on Meta…

I don’t see any console errors on your site… did you edit the theme at all? if you install another copy of it does it have the same issue?

1 Like

A quick look shows that REFACTOR: Update structure, fix for ember-cli (#5) · discourse/discourse-simple-theme@0482a6c · GitHub may have changed the way that page is formatted on Aug 10th.

1 Like

That refactored the theme structure, and fixed an issue with our ember-cli updates, but shouldn’t have changed anything about the layout (it’s also working as expected on our theme creator site: Discourse Theme Creator).

1 Like

I found the problem, looks like those changes conflicted with a component that was in place which resulted int he changes to the displayed format.

Thank you

3 Likes

I’m running into a similar issue with most recent update - updated everything at once so not sure if it was theme, another component, or discourse itself:
Discourse 2.8.0.beta8
10a57825c8

Theme updated November 21 (can’t find version number) ‘up to date’.

Now, read, and unread all show as ‘unread’ secondary blue on desktop, but work correctly on mobile:
Desktop:

Mobile:

Same on various iterations of light, medium, dark schemes that we’ve made…the ‘categories+latest’ main page 2 column layout seems correct with brighter bold unread, and muted unbold read topics; but the ‘latest’ listing is all bold tertiary all the time.

Using preview on other themes (default, and others) seems to show the correct behaviour.

1 Like

Did you solve this issue?

The same for me, everything is shown like unread, other themes work fine.

1 Like

Looking into DevTools, seems like this rule from app/assets/stylesheets/common/base/_topic-list.scss somehow disappears when using this theme

image

1 Like

ah, looks like topic-list-data is missing here.

Submitted PR.

2 Likes

I had not - thank you very much for looking into this :slight_smile:

1 Like

Seems to be fixed in DEV: Prep for pre-topic-list-refactor (#6) · discourse/discourse-simple-theme@b305d81 · GitHub

1 Like

verified the pr was committed in my install - works like a charm :slight_smile:

1 Like

Hi, thanks very much for this traditional theme, it’s much closer to what my migrated legacy forum users would expect!

There appears to be a small bug in the “Suggested Topics” list when clicking on the avatar of the last post user; the user profile briefly appears for a few milliseconds and then disappears.

1 Like

Hi there, another bug is that the cog button doesn’t appear for bulk actions with Sam’s Simple Theme (it does with the Discourse default one):

1 Like

Hi there, are pull requests being accepted for this theme? I submitted a PR a few days ago with a simple 2 line fix for a fairly significant bug that is breaking links to user profiles.

1 Like

This PR has been merged. Thank you for the fix :+1:

4 Likes

Hi there, one of the biggest improvements in this theme is the elimination of the posters column from topic lists, and it simply shows the original poster and the latest poster. However, this paradigm falls apart in the list of private message topics. When the user is both the starter and the latest poster in a PM topic there is no indication of who the other recipient(s) is/are. So it feels like specifically for the PM topics list the default Discourse theme’s posters avatars column needs to be used. Is there a clean way for me to add it back with a theme component until this gets fixed in the official code of Sam’s Simple Theme? Thanks!

1 Like

I’m pretty sure that this is a new regression, in desktop browser mode the latest poster avatar pops up partially off-screen:

1 Like

Hm, I’m unable to reproduce :thinking:

As a side note, this user card modal is from this theme component: Usercard Redesign Experiment

2 Likes

@Arkshine Hi, appreciate the reply. I think it happens when the zoom level is higher. I first noticed the issue on Firefox, where I have the default zoom set to 110%, and also layout.css.devPixelsPerPx set to 1.1 . But I can also reproduce it with Chromium’s default settings by just zooming in a bit (it appears to only happen when the browser is maximized):

Ah, ok. I think I’ll cross-post this issue there. It seems like the usercard component should take care of its own CSS to avoid appearing off-screen. But the issue is complicated by Sam’s Simple Theme, which has the user card closer to the right edge.