Translation for system message not being used

Bug
1

When a post is flagged on a forum that is using a non-English locale, only the flag_reason is being translated. The other text is not translated and displayed in English. There is a translation present in the configuration.

We can repro this on latest stable. Multisite, if that matters.

image
image.png770×471 26.9 KB

image
image.png1150×732 330 KB

3 Likes
2

I think @gerhard may have fixed this a while back?

4

The bug was a little bit different from what you described:

  • It always used the default_locale for the system message.
  • It used the flagger’s locale for the flag reason.

So, in your example, the system locale was set to English and the locale of the user who flagged a post was set to German.

https://github.com/discourse/discourse/commit/badad80cdf4489dd687a723647091c0b6b273ae6

4 Likes
5

So this is resolved, then? If so this can be closed?

2 Likes
6

Yes, and auto-close will take care of it :wink:

3 Likes