IIRC this was essential for some browsers (IE < 10?) because it’s impossible to access <noscript> tags via JavaScript after doing the feature detection. I think @dan worked on this problem a few years back?
Note that there are two fallback ‘modes’ at the moment:
Serve the crawler view. No JS required. This is gated on browser_update_user_agents.
Serve the full app, feature detect, and fallback by moving <noscript> content into <body>. This is not based on user agent.
The problem here is that (2) is not working on mobile, because the server isn’t rendering any <noscript> content. We need to fix that, without breaking (1) for mega-old browsers.
How were you thinking of implementing (2) @sam? Maintain a list of ‘modern’ user agents matchers in core? And then we bump them up as part of the stable release cycle?
Looks like there are some comments to resolve, but it’ll probably be merged in the next 24hrs. We’ll update here when it is. Then, assuming you’re on tests-passed, you’ll be able to visit /admin/upgrade on your forum and pull in the change.
Interestingly in a iphone 5 on browser stack, proxying to local, I am seeing a white page even after I fiddle with include_crawler_content? and set it to true.
There may be some stuff that ember cli is doing on local to break this testing.
It certainly looks broken as designed on iOS 7 in production. (no content cause we don’t ship it)
Going to be reasonably tricky to test the fix, but I guess I can fake some things on local.
This seems to have broken again yesterday. I’m getting a white page with no error message via my browser and the app on the same two out of three forums
That’s now deployed to Meta, and the majority of our hosted customers (including http://community.jenkins.io/). Sites should now load again under iOS 12. Thanks for reporting the issue @wake and @Ian_W!
Great news to see it’s working again. I do appreciate all your efforts.
Just an oddball observation now. I type the url, hit enter and the progress bar slowly completes. Then I initially end up with a blank page, but about 6-7 seconds later, then the content appears! This used to take just about a second (so not really noticeable before). Weird.
