Editing plugin translation strings in the admin panel when the forum language is not defined for the plugin has no effect

[david (David Taylor)]

If the current forum language does not exist in the plugin, then overriding strings in the admin panel does not work.

As an example: if I have a plugin which only has english language translations, and somebody installs it on a french forum, the english strings will be used (this makes sense).

However, if the forum owner goes into the admin panel and tries to update the translation string, that change has no effect.

See today:

Who's Online Plugin (discourse-whos-online)

It’s working fine for label in discourse core, but not for your plugin, or cakeday for example. Thanks.

And also in April:

https://meta.discourse.org/t/customize-all-text-in-discourse/36092/45?u=david_taylor

https://meta.discourse.org/t/customize-all-text-in-discourse/36092/47?u=david_taylor

Could be related to this:

Translation of tagging selector does not change

when i change the text in the tag-selector from “all tags” to the string i want, it remains unaffected: [image] it shouldn’t be cache issue, since i’ve just updated the site. update: i just checked and it seems this happens for some other strings related to “tags” feature.

[david (David Taylor)]

Ran into this issue again today with @Ogulcan. Is there any plan to get it fixed, and if not would someone be able to point me to the right area of the codebase so I can attempt to fix it myself?

[sam (Sam Saffron)]

@eviltrout I have seen this reported elsewhere, perhaps you can add to your list to have a look.

[david (David Taylor)]

Looks like this might be fixed now

Translation fallback issues should be a thing of the past