nathank
(Nathan Kershaw)
June 5, 2024, 7:01pm
24
I took a look at that at the same time, but couldn’t work out how to effectively target the right bit of HTML to hide it.
My issue was that I can’t seem to make SASS variables work in selectors.
If I could work out how to do that, could also make it compatible with alternate lock icon.
1 Like
Glad this was bumped, I’ve had multiple users ask me how they can use a section (that they’ve always been able to use) because they just assume lock=can’t use this.
2 Likes
nathank
(Nathan Kershaw)
June 6, 2024, 12:38pm
26
You can use this TC to change the icon to whatever you like:
I (used to) use unlock-alt
for the very reason you state - until I developed the need to hide them for some categories!!
3 Likes
Lilly
July 28, 2024, 5:38pm
28
This has been merged. Thanks @nathank .
edit: also updated the about info
2 Likes
nathank
(Nathan Kershaw)
July 29, 2024, 12:39am
29
Discovered a regression! When I put in a category/subcategory, it was breaking the TC due to the change above corrupting the CSS.
Fresh PR now (also tidies up something else I missed):
Lillinator:main
← nathan-nz:main
opened 12:37AM - 29 Jul 24 UTC
Fix subcategory regression (category/subcategory input was breaking TC)
Also … ensure Discourse Category Headers TC compatible with staff setting
2 Likes
Lilly
July 29, 2024, 12:49am
30
Merged. thanks Nathan. I didn’t even notice. I loaded it into my test instance and had a quick look, but I didn’t see any errors and it seemed to be working as expected (but admittedly didn’t check subcategories ).
3 Likes
nathank
(Nathan Kershaw)
July 30, 2024, 5:29am
31
And another one!
This one adds the ability to cope with alternative lock icons (from Category Icons ), and tidies up another loose end with the Discourse Category Headers .
Lillinator:main
← nathan-nz:main
opened 05:27AM - 30 Jul 24 UTC
Adds compatibility with the alternative lock icons from github.com/discourse/dis… course-category-icons
Also includes a minor buff to the Discourse Category Headers compatibility
2 Likes
Lilly
July 31, 2024, 12:42pm
32
Merged Nice add - thanks!
I really need to spend some time and finish getting the category list_type chooser working. I just need to get a working findby()
function.
3 Likes