Topic List Previews Theme Component

[merefield (Robert)]

Marking this broken for time being.

I’m not sure when I will get around to investigating this.

[Moin]

Is the Theme component broken or the sidecar Plugin?

[Jagster (Jakke Lehtonen)]

The component works really well. For me, any way. It is the sidecar that is broken.

My bad. I forgot mention it.

[merefield (Robert)]

It’s something to do with rebuilding the rmagick gem.

An online rebuild seems to work.

FYI in any case this Theme Component is about to require a massive refactor due to changes to the Topic List. I can’t guarantee that will be ready in time, but I will try as use it myself.

[merefield (Robert)]

@Jagster online update definitely works … have no idea why, maybe the gem is cached?

If you need to, restart your container and perform an online update.

[merefield (Robert)]

See:

Online update succeeds, but rebuild fails

Came across a curious issue which may highlight another difference between online updates and command line updates. If I perform an online update with a plugin with the rmagick gem, it succeeds. However, it fails with a cli rebuild with: ERROR: Error installing rmagick: ERROR: Failed to build gem native extension. current directory: /var/www/discourse/plugins/discourse-topic-previews-sidecar/gems/3.3.6/gems/rmagick-6.0.1/ext/RMagick /usr/local/bin/ruby extconf.rb checking for brew... n…

[Jagster (Jakke Lehtonen)]

I hadn’t any real reason to do upgraiding, so starting app did the job. And honestly… in my case I’m not sure if I really need the sidecar for anything.

But good to know.

[merefield (Robert)]

it’s mainly useful for YouTube thumbnails, topic list based actions … and currently dominant colour.

[Jagster (Jakke Lehtonen)]

Yeah, that it was… all those plugins that doesn’t need any love and caring, after a while I don’t even remember any more why I had such one in use

[merefield (Robert)]

If someone wants to try this they are welcome, I’ve not had chance yet:

Online update succeeds, but rebuild fails

You can do something like pull in the gem’s compile-time dependencies - something like the following: hooks: after_code: - exec: apt-get update && apt-get install -y libmagickwand-dev we aren’t blocking anything from being installed, we are just no longer including the static libs that the gem is dependent on in the base image.

[merefield (Robert)]

This is fixed now (plugin rebuild) as the reliance on the rmagick gem has been removed and the plugin refactored to accommodate.

Zeitwerk refactor

Note there is still loads of work to do to resolve the deprecations of the Theme Component and this is partly waiting on the kind efforts of David to extend the new Topic List API in core.

Modifying style attribute dynamically on Topic List Item

modifyClass itself is not deprecated. It’s a risky customization method, and you should take precautions when using it (as described in the doc @don linked), but we don’t have any imminent plans to remove it. The reason we’re printing a deprecation message for component:topic-list and component:topic-list-items is that those components are the legacy implementation of the topic list, and are not used when the glimmer topic list is enabled. Now, we have a set of glimmer components like component…

For now I’ve removed the broken tag.